fix(messaging): log malformed settlement messages - #650
Open
zakazaka95 wants to merge 1 commit into
Open
zakazaka95 wants to merge 1 commit into
zakazaka95 wants to merge 1 commit into
Conversation
Make both settlement collectors emit an operator-visible warning with block, transaction index, transaction hash, and conversion reason before skipping malformed messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #621.
Both settlement collectors now emit an operator-visible warning with block, transaction index, transaction hash, and conversion reason before skipping a malformed event or log. Focused regressions cover the Starknet and Ethereum paths and assert both the skip behavior and required diagnostic context.
Validation:
git diff --checkand rustfmt content checks pass; Windows test/check attempts are blocked beforekatana-messagingby existing Linux-onlysp1-jitandreth-mdbx/libclang dependencies, so GitHub CI is the authoritative runtime check.