fix: exclude instance methods from enum member detection#1921
Closed
Dhruva-Das wants to merge 1 commit into
Closed
fix: exclude instance methods from enum member detection#1921Dhruva-Das wants to merge 1 commit into
Dhruva-Das wants to merge 1 commit into
Conversation
_get_enum_members treated any FunctionType in the enum body as a generation choice. Instance methods like describe(self) have a dot in their __qualname__ (ClassName.method), so filter them out to avoid crashing on the unannotated self parameter. Fixes dottxt-ai#1915
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thanks for opening a PR, but the issue was already fixed by #1917 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Defining an Enum with regular instance methods (e.g. a
describe(self)helper) and passing it topython_types_to_termscrashes with a signature parsing error._get_enum_membersindsl.pytreats anyFunctionTypefound in the class body as an enum member value, so it picks up instance methods alongside the actual enum values.Fix
Instance methods defined in a class body have
ClassName.method_namein their__qualname__, while standalone functions used as enum values don't contain a dot. Added a check against__qualname__to filter them out.One-line change in
_get_enum_members, plus a regression test.Testing
describe(self)method to the existingSomeEnumintest_dsl_python_types_to_termstest_enum_with_instance_method_not_treated_as_membercovering a standardEnumwith a helper methodpytest tests/types/test_dsl.pypasses (57 passed, 2 pre-existing Windows tempfile failures unrelated to this change)Fixes #1915