Skip to content

More informative error handling when connection string is ill-formed #75

Description

@hokster7

I tried to hack up database access quickly by writing something like this CoffeeScript, expecting the package to guide me through informative errors:

app.use orm.express '',
  define: (db) ->
    return

, I run into this:

TypeError: Cannot call method 'replace' of undefined
    at Object.exports.connect (<project>/node_modules/orm/lib/ORM.js:58:29)
    at Object.module.exports (<project>/node_modules/orm/lib/Express.js:9:6)
    at Object.exports.express (<project>/node_modules/orm/lib/ORM.js:20:30)

node-orm2 just blindly assumes that there is a colon to be matched in the connection string in ORM.js:58:

var proto  = opts.protocol.replace(/:$/, '');

but in fact, we mustn't assume the connection is valid all the time.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions