Skip to content

Promise support - #807

Merged
dxg merged 116 commits into
dresende:masterfrom
locomote:master
Sep 19, 2017
Merged

dxg merged 116 commits into
dresende:masterfrom
locomote:master

Conversation

@tttmaximttt

Copy link
Copy Markdown
Contributor

Add Promise support for all possible ORM methods. For more info read Readme, Promise chapter.

mradko and others added 30 commits September 11, 2017 09:19
Comment thread lib/ChainFind.js
promise.handle(this.all);
}
return promise.fail(cb);
},

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend we keep these in the code, and just add a console.warn deprecation message & mention deprecation in changelog

@dxg dxg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dxg

dxg commented Sep 19, 2017

Copy link
Copy Markdown
Collaborator

Awesome 👍

@dxg
dxg merged commit 5c6ceb3 into dresende:master Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants