Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
### v6.2.0
- [Feature] Add `.driver.generateQuery` function - same as `.driver.execQuery` but returns the SQL instead of executing it

### v6.1.0
- [Feature] Accept options when calling `Model.create` ([856](../../pull/856))

Expand Down
17 changes: 13 additions & 4 deletions lib/Drivers/DML/_shared.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
var Promise = require('bluebird');

var generateQuery = function (sql, params) {
return this.query.escape(sql, params);
};

var execQuery = function () {
var cb;
var query;

if (arguments.length == 2) {
var query = arguments[0];
var cb = arguments[1];
query = arguments[0];
cb = arguments[1];
} else if (arguments.length == 3) {
var query = this.query.escape(arguments[0], arguments[1]);
var cb = arguments[2];
query = this.generateQuery(arguments[0], arguments[1]);
cb = arguments[2];
}
return this.execSimpleQuery(query, cb);
};
Expand All @@ -30,6 +37,8 @@ var eagerQuery = function (association, opts, keys, cb) {
};

module.exports = {
generateQuery: generateQuery,

execQuery: execQuery,

eagerQuery: eagerQuery,
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"sqlite",
"mongodb"
],
"version": "6.1.0",
"version": "6.2.0",
"license": "MIT",
"homepage": "http://dresende.github.io/node-orm2",
"repository": "http://github.com/dresende/node-orm2.git",
Expand Down
21 changes: 21 additions & 0 deletions test/integration/db.js
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,27 @@ describe("db.driver", function () {
});
});

describe("#generateQuery", function () {
it("should return interpolated & escaped SQL", function () {
var expected = "expectation missing; unknown protocol";

switch (common.protocol()) {
case 'mysql':
case 'sqlite':
expected = "UPDATE `animals` SET `name` = 'cat' WHERE `id` = 9"
break;
case 'postgres':
expected = 'UPDATE "animals" SET "name" = \'cat\' WHERE "id" = 9'
break;
}

should.equal(
db.driver.generateQuery("UPDATE ?? SET ?? = ? WHERE ?? = ?", ['animals', 'name', 'cat', 'id', 9]),
expected,
);
});
});

describe("#execQuery", function () {
it("should execute sql queries", function (done) {
db.driver.execQuery("SELECT id FROM log", function (err, data) {
Expand Down