chore: bump tsdown from 0.22.14 to 0.23.0 in the pnpm-catalog group [AR-89256] - #706
Open
mmurawski-dn wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for drivenets-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mmurawski-dn
force-pushed
the
drivenets/dependabot-pnpm-catalog-fix-821e1f
branch
from
September 9, 2026 13:15
6eb4f18 to
729272c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #687, which could not be fixed in place: tsdown 0.23.0 has breaking changes that need config migration, and that branch was also conflicting with
main.Why #687 failed
deps.skipNodeModulesBundle.ds-main-menucoming-soon hover test was already fixed onmainafter chore: bump tsdown from 0.22.14 to 0.23.0 in the pnpm-catalog group #687 branched off563de4c0(thehoverComingSoonBadgeretry helper). Rebasing clears it.Changes
pnpm-workspace.yaml— catalogtsdown^0.22.14→^0.23.0.tsdown.config.tsmigrated for 0.23:deps.skipNodeModulesBundle: true→deps.neverBundle: true.dts: { tsgo: { path: 'tsc' } }→dts: { generator: 'tsgo', tsgo: { path: 'tsc' } }. In 0.23dts.generatoris the only way to select the generator — the baretsgoobject only configures it, so without this the build silently falls back to the default generator.pnpm-lock.yaml— reinstall pluspnpm dedupe(lint:deduperequires it; chore: bump tsdown from 0.22.14 to 0.23.0 in the pnpm-catalog group #687 needed the same dedupe commit).Verified
resolveDepSubpathflipping tofalseby default in 0.23 does not change externalization:@ark-ui/react/avatarand the other subpath imports are still external in the built output.Verification
Green locally: typecheck, build,
lint:build(publint + attw 🟢 across node10 / node16 CJS+ESM / bundler), lint, format, dedupe, versions, spell, unused, figma:lint,test:requires-build, storybook docs tests (66/66).