Decoding, validation, and path-resolution fixes for cgi-bin scripts#796
Open
b1tw153 wants to merge 18 commits into
Open
Decoding, validation, and path-resolution fixes for cgi-bin scripts#796b1tw153 wants to merge 18 commits into
b1tw153 wants to merge 18 commits into
Conversation
…ectness and parameter validation
…rameter validation
…ess and input validation
…arameter validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/cgi-bin/* (17 scripts)
uncgion stdin usingprintf '%s'to ensure that they are correctly decoded.realpathto ensure that path construction is correct.400for a malformed request and500only for a missing or unreadable backend file. Scripts that render an HTML page fall back to defaults instead of erroring.sitemap: fix incorrect handling of an empty directory.ping: handle error cases and remove a race condition.kill_my_queries: validate the PID argument; construct paths more carefully.$( )fixes throughout.Scripts accept the same inputs and produce the same outputs as before for well-formed requests.
src/pt_diagrams/uncgi.cc
%at the end of the input.uncgiaccepts the same inputs and produces the same outputs as before for well-formed requests.