CGI input/output correctness fixes#797
Open
b1tw153 wants to merge 4 commits into
Open
Conversation
…alue delimiter search to its segment instead of scanning the entire query string, and switch the POST body read to a faster bounded chunked read.
…lized coordinates; widen input-position counters to std::size_t.
…bling template-name sanity check.
… its fixed-offset substrings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cgi-helper.cc / cgi-helper.h
max_input_size. Callers inuser_interface.ccnow pass themax_input_sizevalue.%escape at the end of the input.'='key/value delimiter search to the current query parameter instead of scanning ahead into the rest of the query string.user_interface.cc
bbox=...coordinates to doubles before using them.(bbox)/[bbox]placeholders in a single pass instead of inserting values into the input string.std::size_t.output_custom_factory.cc
urlparameter for[out:custom], matching the existing check for thetemplateparameter.processed_input.cc
operates_Mo_Fr/operates_Sa/operates_Suvalues before taking their fixed-offset substrings.The changes preserve the prior behavior for well-formed requests.