docs(export): correct the GenModelUtilX context Javadoc and test its restore - #1555
Merged
joaodinissf merged 1 commit intoSep 28, 2026
Conversation
…restore Follow-up to dsldevkit#1546. The Javadoc of withModelContext and renderBody called GenModelUtilX shared and said the leak lasted until the thread inferred another export model. The utility is not a singleton, so each inferrer has its own thread-local, and the leaked entry's value kept its own key reachable, so it was never cleared. Add a regression test: inference and the type initializers must leave the GenModelUtilX context as they found it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LgVRfQCTxSDwGrN8J5s6fd
rubenporras
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1546, from a review after it was merged:
withModelContextandrenderBodycalledGenModelUtilXshared and said the leak lasts until the thread infers another export model. Neither holds. The utility isn't a singleton, so each inferrer has its own thread-local, and the leaked entry's value keeps its own key reachable, so the entry was never cleared.GenModelUtilXcontext as they found them.No functional change.
🤖 Generated with Claude Code