fix(test.ui): open the view menu before searching DynamicViewMenu items - #1557
Merged
Merged
Conversation
Since Eclipse 4.41 the Markers views only receive their view menu contributions (Show, Group By, ...) once the view menu is actually opened, so DynamicViewMenu no longer found them. Open it via SWTBotView.viewMenu() first, and throw the WidgetNotFoundException outside syncExec so it is no longer masked as an IndexOutOfBoundsException.
rubenporras
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the change
On the Eclipse 4.41 target,
DynamicViewMenuno longer finds the Markers views' menu items (Show, Group By, ...) unless the view menu has been opened first. Opening it as a user would makes them available on both targets.Special things to note
SWTBotView.viewMenu()opens the view menu as a user would and hides it again, so no popup is left open.syncExec, where it was masked as anIndexOutOfBoundsException.Change outline
🤖 Generated with Claude Code