refactor(expression): take the segments of a Java type name as varargs - #1562
Merged
Merged
Conversation
Three of the callers of javaName split a string into an array and wrapped it in a list only to pass it on, so the method now takes the segments as varargs; the identifier path converts its list once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rubenporras
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the change
Follows up on Ruben's suggestion in #1556: three of the four callers of
javaNamesplit a string into an array and wrapped it in a list only to pass it on, so the method now takes the segments as varargs.Special things to note
addExpressionTypeNames, starts from the identifier'sList<String>and converts it withtoArray(String[]::new).xtext.expression,xtext.exportandxtext.scopeneed a version bump for the release version check, since their content changes against that baseline.Change outline
🤖 Generated with Claude Code