Skip to content

test(xtext): make the case-sensitive exact pattern test discriminate - #1563

Merged
joaodinissf merged 1 commit into
masterfrom
test/case-sensitive-exact-pattern
Sep 30, 2026
Merged

joaodinissf merged 1 commit into
masterfrom
test/case-sensitive-exact-pattern

Conversation

@joaodinissf

Copy link
Copy Markdown
Collaborator

Why the change

testCaseSensitiveExactPattern could not fail for a lookup that ignores case, because no candidate differs from "Other" only in case; adding "other" makes it discriminate.

Special things to note

Change outline

 com.avaloq.tools.ddk.xtext.test/.../PatternAwareEObjectDescriptionLookUpTest.java
+  private static final String OTHER_LOWER_CASE = "other";
+  candidates: … description(OTHER), description(OTHER_LOWER_CASE)

🤖 Generated with Claude Code

The candidates had no name that differs from "Other" only in case, so a
case-insensitive lookup would also have passed the case-sensitive exact
pattern test. Add "other" as a candidate.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@joaodinissf
joaodinissf marked this pull request as ready for review September 30, 2026 14:28
@joaodinissf
joaodinissf merged commit 6d068ac into master Sep 30, 2026
4 checks passed
@joaodinissf
joaodinissf deleted the test/case-sensitive-exact-pattern branch September 30, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants