Fix parent downstream message routing - #3
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
sylvesterkaczmarek
left a comment
Author
There was a problem hiding this comment.
The new parent→child route skips the timestamp adjustment used by PeerConnection before writing to a registered sensor. In no-time-sync deployments, SensorInfo.dmm_msg_offset converts upstream messages back to the ASM's clock, so a parent-routed task can reach the child with the wrong timestamp. Apply _apply_timestamp_offset(..., node_connection.dmm_msg_offset, node_connection.message_format) before the child writer and add a non-zero-offset test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
destination_idto the matching child connectionFixes #2
Testing
test_parent_routes_targeted_message_to_child_without_reflection