Skip to content

Fix parent downstream message routing - #3

Open
sylvesterkaczmarek wants to merge 1 commit into
dstl:masterfrom
sylvesterkaczmarek:fix/parent-message-routing
Open

Fix parent downstream message routing#3
sylvesterkaczmarek wants to merge 1 commit into
dstl:masterfrom
sylvesterkaczmarek:fix/parent-message-routing

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Summary

  • route parent-originated messages with a destination_id to the matching child connection
  • prevent messages from being reflected back to the parent connection they arrived on
  • add regression coverage for targeted child routing and source-parent exclusion

Fixes #2

Testing

  • added test_parent_routes_targeted_message_to_child_without_reflection

@sylvesterkaczmarek sylvesterkaczmarek left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new parent→child route skips the timestamp adjustment used by PeerConnection before writing to a registered sensor. In no-time-sync deployments, SensorInfo.dmm_msg_offset converts upstream messages back to the ASM's clock, so a parent-routed task can reach the child with the wrong timestamp. Apply _apply_timestamp_offset(..., node_connection.dmm_msg_offset, node_connection.message_format) before the child writer and add a non-zero-offset test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ParentConnection.handle_message: missing destination_node_id routing + broken except_writer guard

1 participant