Handle v2-only registration fields in v1 downgrade - #4
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
sylvesterkaczmarek
left a comment
Author
There was a problem hiding this comment.
The downgrade still leaves V2-only RegionType values in registration task definitions. V2 adds REGION_TYPE_MOBILE_NODE_NO_GO_AREA and REGION_TYPE_MOBILE_NODE_GO_AREA, but V1 only defines 0–3; ParseDict(..., V1) will reject such a registration and translate_v2_to_v1() returns an empty message after catching the exception. Remove/translate those region types during downgrade and add a regression alongside the V2-only command test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MOVE_TO,PATROL, andFOLLOWcapability declarations because those command types do not exist in the v1 enumnamefieldAddresses #1
Rationale
BSI Flex 335 v2.0 added extensible taxonomy docking and the
MOVE_TO,PATROL, andFOLLOWcommand types. These have no representation in the v1 registration schema. The downgrade path currently passes them intoParseDict, which rejects the registration.This change makes the downgrade intentionally lossy only for those v2-only registration capabilities while preserving fields that v1 can represent.
Testing
test_v2_registration_downgrade_omits_v2_only_taxonomy_and_commands