Add CPM popup logic - #9446
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4230730. Configure here.
|
|
||
| fun onConfirmClicked() { | ||
| viewModelScope.launch { command.send(Command.Close) } | ||
| } |
There was a problem hiding this comment.
Confirm ignores selected option
High Severity
onConfirmClicked only emits Close and never applies the selected choice via autoconsent. The copy offers enabling protection / accepting non-rejectable cookies (MAX) vs leaving things unchanged (KEEP_CURRENT), so Confirm currently discards the choice and leaves settings untouched.
Please tell me if this was useful or not with a 👍 or 👎.
Reviewed by Cursor Bugbot for commit 4230730. Configure here.
| applicationContext.startActivity(intent, options) | ||
| } | ||
|
|
||
| return@withContext ModalEvaluator.EvaluationResult.ModalShown |
There was a problem hiding this comment.
Prompt can reappear forever
High Severity
evaluate returns ModalShown whenever cookiePopUpOptInPrompt is enabled, with no local already-shown / dismissed gate. Peer modal evaluators persist eligibility after display. While the toggle stays on, this prompt can resurface after each coordinator cooldown and keep claiming the modal slot.
Please tell me if this was useful or not with a 👍 or 👎.
Reviewed by Cursor Bugbot for commit 4230730. Configure here.
1 participant
Task/Issue URL:
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
Steps to test this PR
Feature 1
UI changes
Stack created with GitHub Stacks CLI • Give Feedback 💬
Note
Medium Risk
New modal can interrupt browsing when the toggle is on, and confirm does not apply preferences yet—worth validating against follow-up logic before wide rollout.
Overview
Adds a Cookie Pop-Up Protection opt-in bottom sheet, gated by a new internal
cookiePopUpOptInPromptremote toggle and shown through the prompts coordinator (CookiePopupOptInEvaluatorat priority 6).The modal is onboarding-styled (translucent activity, slide animations, two selectable options) with copy that switches between protection on vs off based on
Autoconsent.isSettingEnabled(). Confirm currently only dismisses the sheet—it does not persist the selected option in this diff.Also wires
prompts-coordinator-apiinto autoconsent-impl, refreshes the enabled-state header asset tocookie_popups_check_96, and points onboarding’s input-type background at the sharedCommonRdrawable.Reviewed by Cursor Bugbot for commit 4230730. Bugbot is set up for automated code reviews on this repo. Configure here.