Handle C-S-S passkeyUsed notifications by parsing and logging - #9495
Draft
dbajpeyi wants to merge 4 commits into
Draft
Handle C-S-S passkeyUsed notifications by parsing and logging#9495dbajpeyi wants to merge 4 commits into
dbajpeyi wants to merge 4 commits into
Conversation
Adds a dedicated handler pair for the webCompat/passkeyUsed
notification that content-scope-scripts sends when a WebAuthn passkey
ceremony completes ({ type: get|create, success: boolean, error? }).
Follows the ContentScopeJsMessageHandlersPlugin pattern (e.g.
DecryptWithSyncMasterKeyHandler), with a WebViewCompat twin so the
message is handled on either C-S-S transport. Unlike the existing
webCompat request/response handlers there is intentionally no id
guard: this is a notify() message and carries no id.
For now the payload is only parsed and logged; pixel firing is a
follow-up (definitions in PR #7183).
Point at pr-releases/cursor/passkey-usage-detection-e6be rather than the source branch. The source branch has no committed build output, so installing from it removed the vendored build/android bundles; the pr-releases branch ships the built artifacts the app actually consumes. Resolves to 72cc2f8, the build-artifacts commit on top of source commit 1d01d1b, and refreshes the two vendored bundles that include webCompat so the app picks up passkey detection.
Adds android.util.Log.i("PasskeyUsedDbg", ...) at both transport
handlers' process() entry and inside PasskeyUsedMessageLogger.log().
android.util.Log writes regardless of the debuggable flag or whether
the logcat{} logger is installed, so this isolates whether the message
is being routed to the handler at all versus a logging-visibility issue.
Tests switched to Robolectric so the android.util.Log calls resolve.
Revert before merge - this is throwaway on-device diagnostics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dedicated handler pair for the webCompat/passkeyUsed notification that content-scope-scripts sends when a WebAuthn passkey ceremony completes ({ type: get|create, success: boolean, error? }).
Follows the ContentScopeJsMessageHandlersPlugin pattern (e.g. DecryptWithSyncMasterKeyHandler), with a WebViewCompat twin so the message is handled on either C-S-S transport. Unlike the existing webCompat request/response handlers there is intentionally no id guard: this is a notify() message and carries no id.
For now the payload is only parsed and logged; pixel firing is a follow-up (definitions in PR #7183).
Task/Issue URL:
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable):
Description
Steps to test this PR
Feature 1
UI changes