Request translations for Duck.ai edit message screen - #9498
Open
malmstein wants to merge 13 commits into
Open
Conversation
Move the edit message screen strings out of donottranslate.xml so the Smartling connector picks them up, and add translator instructions for both. The cancel content description reused the same copy as the design system's cancel string, which is already translated in all supported locales, so point at that instead of translating a duplicate. https://app.asana.com/1/137249556945/task/1217486650298566
Translate strings-duckchat to values-fi
Translate strings-duckchat to values-pt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/task/1217486650298566
Tech Design URL (if applicable):
API Proposals URL(s) (if applicable): None
Description
Requests Smartling translations for the Duck.ai edit message screen.
The screen's copy was sitting in
donottranslate.xmlwhile the feature was in development. This moves it intostrings-duckchat.xmlso the repository connector picks it up, and adds aninstructionto each string so translators know what they are looking at:duck_ai_edit_prompt_title— "Edit message"duck_ai_edit_prompt_lose_responses_warning— "Editing will replace the response with a new one."duck_ai_edit_prompt_cancelis gone rather than translated. It was the same copy as the design system'scancelstring, which is already translated in all 24 supported locales, so the toolbar's navigation content description now points at that.Translations will land as further commits on this branch, one per language, over the next few days. Lint's
MissingTranslationfails until every locale is in, so CI stays red until the last one arrives.Steps to test this PR
Edit message screen
instructionattributes rather than the generated translations — those come from SmartlingUI changes
Note
Low Risk
String resource and accessibility label changes only; no chat or networking logic.
Overview
Moves Duck.ai edit message copy from
donottranslate.xmlintostrings-duckchat.xmlwithinstructionattributes so Smartling can translate the screen title and the warning that editing replaces the prior response.EditPromptActivitynow uses the shared design-systemcancelstring for the close button’s TalkBack label instead of a duplicateduck_ai_edit_prompt_cancelkey.Adds
duck_ai_edit_prompt_titleandduck_ai_edit_prompt_lose_responses_warningacross the locales in this branch (including Estonian and others). CI may stay red until every locale is present forMissingTranslation.Minor string-resource housekeeping: contextual sheet hint comment no longer references the
contextualSheetImprovementsflag; Frenchinput_screen_search_only_hinttext is adjusted.Reviewed by Cursor Bugbot for commit 76bd524. Bugbot is set up for automated code reviews on this repo. Configure here.