Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Update the uW Mitered Bend footprint wizard to be compatible with KiCad 9 pcbnew Python API changes.
Files changed: ./rf_tools_wizards/uwMitered_wizard.py
What I changed:
Fix SetAnchorPadShape call: pass layer first to match KiCad 9 signature; keep a fallback for older bindings.
Fix polygon primitive creation: build a PCB_SHAPE polygon for the padstack path and call AddPrimitive(shape, layer);
call AddPrimitivePoly(layer, vpoints, thickness, filled) for the modern wrapper signature.
Fix LSET construction: add helper singleLayerSet() that builds an LSEQ and constructs an LSET from it instead of calling LSET(layer) which fails under KiCad 9.
Preserve compatibility: keep conditional branches (e.g., hasattr(pcbnew, 'D_PAD') and try/fallbacks so older KiCad versions remain supported where possible.
Why: KiCad 9 changed several pcbnew Python bindings (pad anchor shape signature, primitive polygon/primitive APIs, and layer-set construction). These changes caused the wizard to raise exceptions; the PR updates the script to call the new APIs correctly while keeping backward-compatible paths where feasible.