Skip to content

oto: fix a uint32 underflow of WASAPI write frames #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hajimehoshi merged 2 commits into from
Sep 12, 2026
Merged

oto: fix a uint32 underflow of WASAPI write frames #297

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdb7d0f
oto: fix a uint32 underflow of WASAPI write frames
kumagi Sep 10, 2026
95d6bb6
oto: guard against a uint32 underflow of WASAPI write frames
kumagi Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions driver_wasapi_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,10 +466,13 @@ func (c *wasapiContext) writeOnRenderThread() error {
return err
}

frames := c.bufferFrames - paddingFrames
if frames <= 0 {
// Defensive check: WASAPI should never report more padding than the buffer size,
// but if it did, the uint32 subtraction below would wrap around to a huge frame
// count and GetBuffer would fail, so skip the write instead.
if paddingFrames >= c.bufferFrames {
return nil
}
frames := c.bufferFrames - paddingFrames

// Get the destination buffer.
dstBuf, err := c.renderClient.GetBuffer(frames)
Expand Down
Loading