Skip to content

android: reject a zero sample rate or channel count in oto_oboe_Play #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kumagi wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

android: reject a zero sample rate or channel count in oto_oboe_Play #303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/oboe/binding_android.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,15 @@ void Stream::DeferStartLocked() {

const char *Stream::Play(int sample_rate, int channel_num,
int buffer_size_in_bytes) {
// The frame counts and the read wait below divide by these, so a value the
// caller left at zero would fault instead of reporting a bad configuration.
if (sample_rate <= 0) {
return "oto_oboe_Play: sample rate must be positive";
}
if (channel_num <= 0) {
return "oto_oboe_Play: channel count must be positive";
}

std::lock_guard<std::mutex> lock{mutex_};
sample_rate_ = sample_rate;
channel_num_ = channel_num;
Expand Down
Loading