Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
None
What type of issue is this addressing?
bug
What this PR does | solves
Seeking a player whose source does not implement
io.Seekercurrently discards its buffered audio before returning an error. Check the source first so that an unsupported seek leaves the buffered data and playback state intact.The regression test covers playing and paused players, and verifies that the buffered samples can still be played after the error. It fails on main because the buffer becomes empty. Successful seeks and errors returned by an underlying
io.Seekerretain their existing behavior.Validation:
go test ./...,go test -race ./internal/mux, andgo vet ./...pass.