Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
None
What type of issue is this addressing?
bug
What this PR does | solves
If
AudioWorklet.addModulerejects (for example, when CSP blocks the Blob script), Oto currently leavesContext.Err()nil. A subsequent user gesture even closes the ready channel although no output node was connected.Record the rejection and close the ready channel on failure without requiring user interaction. On success, wait for both the module connection and audio resume before closing it. Revoke the Blob URL and release the module callbacks in either case.
Initialization also removes the gesture listeners when it fails. Resume callbacks remain alive until their own promise settles, so a late resume cannot call a released function or close the ready channel twice. Pending resume requests are coalesced; a rejected resume leaves the next gesture able to retry.
Validation
Built a small js/wasm program that calls
NewContextand observes the ready channel andContext.Err(), then ran it in headless Chrome 153.0.8010.52 with its real Web Audio implementation.script-src 'self' 'wasm-unsafe-eval'; worker-src 'none'to reject the Blob worklet. Before this change, Chrome reports an unhandled rejection and Oto reports readiness after a click with a nil error. Afterward, readiness closes with the load error even before a click, and the Blob URL is revoked.audioWorklethidden by the harness.GOOS=js GOARCH=wasm go buildandgo vet ./...pass.The timing gates and fallback/error injection were confined to the browser harness; the CSP rejection and normal worklet loading used the browser APIs. Firefox and Safari were not tested.