-
Notifications
You must be signed in to change notification settings - Fork 133
Objc block invoke foreign #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TotallyGamerJet
wants to merge
8
commits into
ebitengine:main
Choose a base branch
from
TotallyGamerJet:objc-block-invoke-foreign
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+976
−9
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c624ff7
objc: let Invoke and InvokeBlock call blocks not created by NewBlock
TotallyGamerJet 9fb80e2
objc: test foreign blocks with an NSItemProvider completion handler
TotallyGamerJet fc7f91a
objc: test foreign blocks with blocks created in Objective-C
TotallyGamerJet 04074b8
objc: share an Objective-C shared library builder between tests
TotallyGamerJet 9be702e
remove some comments
TotallyGamerJet d92dd6e
objc: check foreign block calls against the block's signature
TotallyGamerJet 87dc024
objc: compare foreign block calls against the block's ABI
TotallyGamerJet 999cfc7
objc: treat blank struct fields as padding when matching block signat…
TotallyGamerJet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // SPDX-FileCopyrightText: 2026 The Ebitengine Authors | ||
|
|
||
| package objc_test | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
| "os/exec" | ||
| "runtime" | ||
| "strings" | ||
| "testing" | ||
| ) | ||
|
|
||
| // buildSharedLib compiles the Objective-C sources into a dynamic library at libFile. | ||
| // The library is built for GOARCH rather than the compiler's default, because | ||
| // macOS arm64 can run amd64 tests through Rosetta. | ||
| func buildSharedLib(tb testing.TB, libFile string, sources ...string) error { | ||
| tb.Helper() | ||
|
|
||
| out, err := exec.Command("go", "env", "CC").Output() | ||
| if err != nil { | ||
| return fmt.Errorf("go env CC error: %w", err) | ||
| } | ||
| compiler := strings.TrimSpace(string(out)) | ||
| if compiler == "" { | ||
| return errors.New("compiler not found") | ||
| } | ||
|
|
||
| var arch string | ||
| switch runtime.GOARCH { | ||
| case "arm64": | ||
| arch = "arm64" | ||
| case "amd64": | ||
| arch = "x86_64" | ||
| default: | ||
| return fmt.Errorf("unknown macOS architecture %s", runtime.GOARCH) | ||
| } | ||
|
|
||
| args := []string{"-dynamiclib", "-Wall", "-Werror", "-arch", arch, "-framework", "Foundation", "-o", libFile} | ||
| cmd := exec.Command(compiler, append(args, sources...)...) | ||
| if out, err := cmd.CombinedOutput(); err != nil { | ||
| return fmt.Errorf("compile lib: %w\n%q\n%s", err, cmd, string(out)) | ||
| } | ||
| return nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.