all: remove the fakecgo -std note from NetBSD in README - #538
Merged
hajimehoshi merged 1 commit intoOct 2, 2026
Merged
Conversation
hajimehoshi
approved these changes
Oct 2, 2026
hajimehoshi
left a comment
hajimehoshi
left a comment
Member
There was a problem hiding this comment.
LGTM
@TotallyGamerJet PTAL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
No issue, it's one footnote in the README.
What type of issue is this addressing?
bug, just about
What this PR does | solves
Takes note 4 off the NetBSD line, only FreeBSD needs that flag.
It's there for the two
//go:cgo_export_dynamiclines infreebsd.go, which compiler refuses without-std("only allowed in cgo-generated code").netbsd.gohas none, soGOOS=netbsd CGO_ENABLED=0 go build ./...goes through as it is on amd64 and arm64 (cross-built from Linux, not run on NetBSD itself). The cross-builds intest.ymlallready do NetBSD with no flag, and the comment there says it's for FreeBSD.