Skip to content

Rename showResizeFeedback and eraseResizeFeedback in AbsoluteBasedLayoutEditPolicy #1627

Description

@ptziegler

They should be called showSourceFeedback and eraseSourceFeedback to match the GEF API. We need to explicitly check whether the request type is AbsoluteBasedSelectionEditPolicy.REQ_RESIZE. This then also makes the workaround in the AbsoluteBasedSelectionEditPolicy obsolete.

@Override
protected void showSourceFeedback() {
getLayoutEditPolicy().showResizeFeedback(getSourceRequest());
setShowingFeedback(true);
}
@Override
protected void eraseSourceFeedback() {
if (isShowingFeedback()) {
setShowingFeedback(false);
getLayoutEditPolicy().eraseResizeFeedback(getSourceRequest());
}
}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions