Skip to content

[GEF] MoveHandle should use GEF DragEditPartsTracker directly #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptziegler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[GEF] MoveHandle should use GEF DragEditPartsTracker directly #1619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions org.eclipse.wb.core/src-gef/org/eclipse/wb/gef/graphical/handles/MoveHandle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,7 @@
*******************************************************************************/
package org.eclipse.wb.gef.graphical.handles;

import org.eclipse.wb.gef.core.tools.DragEditPartTracker;

import org.eclipse.draw2d.Locator;
import org.eclipse.gef.DragTracker;
import org.eclipse.gef.EditPart;
import org.eclipse.gef.GraphicalEditPart;
import org.eclipse.gef.handles.MoveHandleLocator;
Expand Down Expand Up @@ -47,11 +44,4 @@ public MoveHandle(GraphicalEditPart owner) {
public MoveHandle(GraphicalEditPart owner, Locator locator) {
super(owner, locator);
}

@Override
protected DragTracker createDragTracker() {
DragEditPartTracker tracker = new DragEditPartTracker(getOwner());
tracker.setDefaultCursor(getCursor());
return tracker;
}
}
4 changes: 4 additions & 0 deletions ...eclipse/wb/internal/core/gef/policy/layout/generic/AbstractContainerRequestValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ public boolean validateAddRequest(EditPart host, ChangeBoundsRequest request) {
//
////////////////////////////////////////////////////////////////////////////
private boolean validateComponents(ChangeBoundsRequest request) {
// Might not be set when called from within "createOperationSet()"
if (request.getEditParts() == null) {
return true;
}
for (EditPart editPart : request.getEditParts()) {
Object object = editPart.getModel();
if (!m_container.validateComponent(object)) {
Expand Down
Loading