[Draw2D] Align Layer with Draw2D implementation - #1650
Merged
Merged
Conversation
The layer name should not be stored as a local variable in the Layer class. Instead it should be used as constraint when adding the figure to the root figure. Note that the root figure still keeps track of all registered layers by name. This will be changed in the future, where the layers are added to a LayeredPane instead. It is also not yet possible to remove this forked class, as it is used in methods which are API. Deprecation will be handled in a follow-up PR.
Test Results 4 files ±0 4 suites ±0 2h 25m 25s ⏱️ + 2m 6s Results for commit 455428c. ± Comparison against base commit 3dd1906. This pull request removes 3 tests. |
Contributor
Author
|
The Jenkins test failure is similar to #1645. I'll prepare a PR for that separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The layer name should not be stored as a local variable in the Layer class. Instead it should be used as constraint when adding the figure to the root figure.
Note that the root figure still keeps track of all registered layers by name. This will be changed in the future, where the layers are added to a LayeredPane instead. It is also not yet possible to remove this forked class, as it is used in methods which are API. Deprecation will be handled in a follow-up PR.