feature: Add BracePairFoldingRegionProvider and tests (#3795) - #3807
Open
ArneDeutsch wants to merge 1 commit into
Open
ArneDeutsch wants to merge 1 commit into
ArneDeutsch wants to merge 1 commit into
Conversation
Contributor
Author
|
The failure looks like an unstable test to me (unrelated): Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.336 s <<< FAILURE! -- in org.eclipse.xtext.ui.tests.editor.hover.AbstractProblemHoverTest |
ArneDeutsch
force-pushed
the
ad-folding-region-nested-braces
branch
2 times, most recently
from
September 22, 2026 09:30
093c7b1 to
5d70f37
Compare
…3795). Signed-off-by: Arne Deutsch <adeutsch@itemis.de>
ArneDeutsch
force-pushed
the
ad-folding-region-nested-braces
branch
from
September 23, 2026 05:40
5d70f37 to
564104b
Compare
|
Thank you @ArneDeutsch : LGTM, approved from my side :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented an alternative folding provider that works on the base of IBracePairProvider. It does NOT fold the EObjects but instead folds the regions based on the brace pairs (default are the pairs {}, () and [] ). Users have to use BracePairFoldingRegionProvider instead of DefaultFoldingRegionProvider and can adapt behaviour by using different implementation of IBracePairProvider.