Skip to content

feature: Add code mining fragment to standard language (#3810) - #3811

Open
ArneDeutsch wants to merge 1 commit into
eclipse-xtext:mainfrom
ArneDeutsch:ad-standard-codemining-fragment
Open

ArneDeutsch wants to merge 1 commit into
eclipse-xtext:mainfrom
ArneDeutsch:ad-standard-codemining-fragment

Conversation

@ArneDeutsch

Copy link
Copy Markdown
Contributor

The example projects serve as test that the feature actually works as expected. By default no code mining stubs are created (null assigned, opt-in).

…#3810)

The example projects serve as test that the feature actually works as
expected. By default no code mining stubs are created (null assigned,
opt-in).

Signed-off-by: Arne Deutsch <adeutsch@itemis.de>
@ArneDeutsch

Copy link
Copy Markdown
Contributor Author

Solves #3810

@github-actions

Copy link
Copy Markdown

Test Results

  6 445 files  ±0    6 445 suites  ±0   2h 58m 6s ⏱️ - 15m 37s
 43 167 tests ±0   42 583 ✅ +1    584 💤 ±0  0 ❌ ±0 
169 964 runs  ±0  167 627 ✅ +1  2 337 💤 ±0  0 ❌ ±0 

Results for commit f0a1eed. ± Comparison against base commit 8b36815.

@cdietrich

Copy link
Copy Markdown
Contributor

this is blocked by point 3 and 4 of
#3778

prs for these would be welcome

@ArneDeutsch

Copy link
Copy Markdown
Contributor Author

PR for point 3: xtext/xtext-reference-projects#564

@ArneDeutsch

Copy link
Copy Markdown
Contributor Author

PR for point 4: xtext/xtext-reference-projects#565

@tamasmiklossy

Copy link
Copy Markdown

Since both PRs that were blocking this have been already merged, I suggest to merge this as well.
LGTM, approved from my side, thanks @ArneDeutsch !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants