Conversation
fabianhjr
marked this pull request as draft
May 3, 2020 03:50
fabianhjr
force-pushed
the
generalize-nat-hack
branch
2 times, most recently
from
May 3, 2020 04:31
3948eaa to
2840e23
Compare
fabianhjr
marked this pull request as ready for review
May 3, 2020 04:37
Contributor
Author
|
Helped me improve the performance of an alternative idris2 prelude I am playing with, tested with mock of ProjectEuler problem #1: |
fabianhjr
force-pushed
the
generalize-nat-hack
branch
2 times, most recently
from
May 3, 2020 07:02
2e4ecb6 to
cd106f6
Compare
fabianhjr
marked this pull request as draft
May 3, 2020 07:05
Contributor
Author
|
Marceline discovered that this PR causes an explosion of memory usage while compiling Idris2 in Core/Binary (Extra ~ 5GB or so of memory usage) |
fabianhjr
marked this pull request as ready for review
May 3, 2020 07:33
fabianhjr
force-pushed
the
generalize-nat-hack
branch
from
May 8, 2020 04:52
cd106f6 to
16550e6
Compare
Owner
|
This does make the nat hack a bit less hacky, thanks! Is the compile time performance still an issue? Sometimes that can be due to ambiguity resolution going a bit out of control. |
Contributor
Author
|
Yes, there is still an issue with Idris1 compilation of Idris2. Idris2 runs fine though. |
gallais
reviewed
May 10, 2020
|
|
||
| -- Prim Nat Optimizations | ||
|
|
||
| <|> do pragma "builtinNatZero" |
Collaborator
There was a problem hiding this comment.
Could we refactor this as something like:
do c <- builtinPragma
n <- name
atEnd indents
pure (c n)
where builtinPragma is a big choice of parsers of the form
PrimNatSucc <$ pragma "builtinNatSucc"
Co-authored-by: MarcelineVQ <marcythevq@gmail.com>
fabianhjr
force-pushed
the
generalize-nat-hack
branch
from
May 15, 2020 16:44
16550e6 to
a8e099b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.