test: enable high-verbosity logging in every component test config - #316
Merged
Conversation
None of the component test configs declared a logger: component, which makes ESPHome silently compile ESP_LOGCONFIG/ESP_LOGW down to no-ops and skip type-checking their arguments entirely (see #315, where this exact gap let a broken ESPBTUUID::to_str() call through CI). Add logger: level: VERY_VERBOSE to every component's test config (via the shared common.yaml where one exists) so dump_config() and warning-log code paths actually get compiled and type-checked. Recompiled every component's esp32-idf/esp32-ard test config with this change and fixed the one warning it caught: a %u format specifier vs. uint32_t argument mismatch in divoom_display.cpp's dump_config(), the same class of bug already fixed in ble_elm327. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
logger:component — ESPHome silently stripsESP_LOGCONFIG/ESP_LOGWcalls down to no-ops in that case and never type-checks their arguments. This PR closes that gap so it can't happen again.logger: level: VERY_VERBOSEto every component's test config (in the sharedcommon.yaml/common_rx_features.yamlwhere one exists, so all variants of a component inherit it in one place).%uformat specifier vs.uint32_targument mismatch indivoom_display.cpp'sdump_config()(same class of issue already fixed inble_elm327in fix: clean up build warnings and sync Colorado Tab5 package #314) — fixed here too.Test plan
esphome compilefor all 16 esp32-idf/esp32-ard test configs across every component — allSuccessfully compiled program., zero warnings in our code.🤖 Generated with Claude Code