i18n: add Brazilian Portuguese (pt-BR) translation - #184
marcobabinski wants to merge 5 commits into
Conversation
|
This is a really good first translation, and thanks for the questions. They are all worth asking. I checked the file over before answering: 713 of 713 keys present, no stray keys, every Answers, in order. 1. Gender. Masculine, o Vice. Your reasoning is the same as mine and you have used it consistently, so nothing to change. 2. Discord Rich Presence. You are right to leave it in English. The daemon sends that string literally, 3. Tap vs click. Your call, and keep clique. The English says "tap" because that is how I write about pressing a key, but the point of the string is what feels natural to the person reading it, and on a Linux desktop you click a thing with a mouse. On your own language you get the final word over me anyway. 4. Deadlock. Yes, Valve's. And you are right that it is a bad choice, I did not think about the computing term at all and now I cannot unsee it. That is a problem in the English rather than something you should work around, so I will change 5. 6. Tooling. Yes, worth having, and it is the right thing to ask for. If you want to open those helpers as their own PR, they are yours and I will take them. If you would rather not, say so and I will add Two things before I merge, both small. The bundle is one commit behind the JSON. Two typos in So: Push that to the same branch and I will merge it. Everything else is ready to go. By the way, the tests will not catch a stale bundle in a non-English locale right now, which is my gap and not yours. Thanks for offering to keep checking in as new strings land. That is genuinely the part that makes a translation worth having. |
|
Sorry for taking so long, it's done. I would be very grateful if you made the tooling though. Especially to keep track of the cognates and checking for missing/new entries. I personally don't know how I would handle things like modified entries (which might be the case for |
|
Thanks for completing the requested translation and bundle corrections. The PR is now based on the commit before the 2.11.0 release and the installer merge, so GitHub reports a merge conflict. Please update this branch from current main and push the result. I will rerun the focused checks and merge it through this PR once it is clean. I will add your handle to the README credits when it lands. |
|
Checked the merge result locally: every placeholder matches English, no stray keys, the UI static tests pass, and the coverage check reads 94% with the rest falling back to English, which is exactly how this is meant to work. No need to chase 100%. One thing left, and it is my fault: I pushed a UI change to main today, so the built bundle conflicts. Nothing in your translation conflicts. Merge main and rebuild: That change also added a handful of new English strings (a storage readout on Home, a couple of gallery lines). They will fall back to English if you leave them, so translate them only if you feel like it. Push that and I will approve the CI run and merge. You will be credited in the 2.13.0 notes and the README. |
|
OK, I've included translations for the new strings in the build, although I wasn't able to find some of them in the UI to get the full context. If I stumble across any confusing ones later, I'll update them. Rebuilt on top of 2.14.0. |
Hello, I have a few questions/notes before merging:
Gender of "Vice": Portuguese is a gendered language, so assigning a grammatical gender to the app name makes phrasing sound much more natural. I am currently leaning towards masculine (o Vice), as it inherits the gender from "game clip recorder" (o gravador de clipes). Do you have any objections or personal preference regarding this?
Discord Rich Presence string: In
settings.discordEnabledHelp, the template"Clipping <Game> with Vice"seems to match what is displayed in Discord's Rich Presence. Since Discord RP status strings are usually kept in English or controlled upstream, I kept this literal quote in English within the description. Is that correct?"Tap" vs. "Click": Strings like
home.tapToCopyuse the word "tap". Since Vice is a Linux desktop application, I localized these using mouse-oriented terms like "clique" / "clicar" (to click) instead of touch terms like "toque" / "tocar" (to tap), which can sound unusual to desktop users.Game title in accents.previewChip: Just to confirm, "Deadlock" here refers to Valve's game Deadlock, right? I ask because the game wasn't the first thing that popped into my head, and it might be the same for other users given that "deadlock" is also a computing term. If that's the case, I'd suggest using a more obvious game title here just to avoid any ambiguity.
Grammar compromise in
update.youAreOn: Portuguese requires contractions that combine prepositions with gendered articles (em + a = na / "on the [feminine]"). Because{version}can be either a specific version number or the fallback phraseupdate.olderRelease("an older release"), there is no single contraction that fits both perfectly:v2.9)update.olderRelease)em(in / on)na(on the [fem.])To prevent broken grammar on the fallback string, I chose
emso both cases remain valid and understandable.check-localestooling to help track newly added strings or upstream copy changes across releases? While working on this PR, I added some local helpers to inspect--missingand--untouchedkeys to distinguish actual untranslated strings from intentional cognates.That’s all! Thanks for the hard work building and maintaining Vice. I plan to keep checking in periodically to translate new strings as features land.