Fix AI health-check 500 when AI is not configured - #314
Merged
Conversation
GET /ai/health-check crashed with ValueError: unknown url type 'None/models' because validate_settings() only rejected None. Default placeholders (empty host/model, port 0) passed validation, _base_url stayed unset, and urllib raised outside the try/except. Treat empty values as unconfigured, avoid str(None) becoming the string "None", and return False from ai_health_check() when the base URL is missing so the UI can hide AI features instead of 500. Signed-off-by: Luigi Pellecchia <pellecchia.luigi@gmail.com>
pellecchialuigi
marked this pull request as ready for review
August 27, 2026 10:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GET /ai/health-check crashed with ValueError: unknown url type 'None/models' because validate_settings() only rejected None. Default placeholders (empty host/model, port 0) passed validation, _base_url stayed unset, and urllib raised outside the try/except.
Treat empty values as unconfigured, avoid str(None) becoming the string "None", and return False from ai_health_check() when the base URL is missing so the UI can hide AI features instead of 500.
Solves #317