Fix combine tmt path - #315
Merged
Merged
Conversation
…iles Selecting a user file in Edit Test Case sent repository as the BASIL root and relative-path as /api/user-files/<id>/..., which starts with a slash. os.path.join treated that as absolute, dropped the repository, and the local-file safety check rejected /api/user-files/... with HTTP 400. Join repository and relative path through combine_tmt_path() everywhere a TMT filesystem path is built, and split user-file paths in the UI through splitUserFileToTmtPath(). Cover the join on API, Test Specification, and Software Requirement mappings, plus E2E add/edit from user files. Signed-off-by: Luigi Pellecchia <pellecchia.luigi@gmail.com>
pellecchialuigi
force-pushed
the
fix-combine-tmt-path
branch
from
August 27, 2026 08:33
5595b61 to
99422f2
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
pellecchialuigi
marked this pull request as ready for review
August 27, 2026 10:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #316