fix: remove crlf server transaction test - #351
Merged
Merged
Conversation
Test asserted validation that 0cd2c53 moved out of the library and into the caller's responsibility. It also panics on a ServerTx without Init() (transaction.go:244), which fails go test ./... on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: remove crlf server transaction test
TestServerTransactionRespondRejectsCRLFasserted CRLF-injection validationwhich was moved out of
ServerTx.Respondand into the caller's responsibility, per the README'sSECURITY section.
The test also constructs a
ServerTxwithout callingtx.Init(), so itpanics on a nil FSM state which breaks tests on main.
This is the server-side counterpart of the earlier removal of the equivalent client-side tests.