Skip to content

Dependency Issue: sass-loader and webpack 2/3 #68

Description

@steverabino

What

Give a detailed description of WHAT this issue seeks to address or add to the build.

When running yarn, the following warning is shown

warning "sass-loader@6.0.6" has incorrect peer dependency "webpack@^2.0.0 || >= 3.0.0-rc.0 || ^3.0.0".

I believe if we're going to be using webpack v1, we need to use this branch of sass-loader: https://github.com/webpack-contrib/sass-loader/tree/archive/webpack-1 (not sure the release version number)

How

  • Use version of sass-loader compatible with webpack v1 OR
  • Upgrade webpack to version 2 or 3

Considerations

  • This is not currently breaking anything, but probably not good practice, and some functionality of sass-loader will not work with webpack v1

  • Is this issue dependent on any others? No

  • Should the assigned consult with anyone in particular before proceeding? No

To Do

  • Use version of sass-loader compatible with webpack v1 OR
  • Upgrade webpack to version 2 or 3

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions