Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/mambajs/src/solverpip.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ interface IWheelInfo {
platformTags: string[];
}

function normalizePackageName(packageName: string): string {
return packageName.toLowerCase().replace(/[-_.]+/g, '-');
}

function parseWheelFilename(filename: string): IWheelInfo {
if (!filename.endsWith('.whl')) {
throw new Error('Invalid wheel filename: must end with .whl');
Expand Down Expand Up @@ -590,7 +594,11 @@ export async function processRequirement(options: {

// Don't pass down parent extras unless needed (PyPI handles it via markers)
parsedRequirement.extras = undefined;
if (installedCondaPackagesNames.has(parsedRequirement.package)) {
if (
installedCondaPackagesNames.has(
normalizePackageName(parsedRequirement.package)
)
) {
if (!warnedPackages.has(parsedRequirement.package)) {
logger?.log(
`Requirement ${parsedRequirement.package} already satisfied.`
Expand Down Expand Up @@ -657,7 +665,7 @@ export async function solvePip(
const installedCondaPackagesNames = new Set<string>();
for (const installedPackage of Object.values(installedCondaPackages)) {
const pipPackageName = await getPipPackageName(installedPackage.name);
installedCondaPackagesNames.add(pipPackageName);
installedCondaPackagesNames.add(normalizePackageName(pipPackageName));
}

// Create pip package lookup we can more easily use (index by package name, not wheel name)
Expand All @@ -669,8 +677,9 @@ export async function solvePip(
const warnedPackages = new Set<string>();
const pipSolvedPackages: ISolvedPipPackages = { ...installedPipPackages };
for (const spec of specs) {
const normalizedSpecName = normalizePackageName(spec.package);
// Ignoring already installed package via conda
if (installedCondaPackagesNames.has(spec.package)) {
if (installedCondaPackagesNames.has(normalizedSpecName)) {
logger?.log(
`Requirement ${spec.package} already handled by conda/micromamba/mamba.`
);
Expand Down
35 changes: 35 additions & 0 deletions unittests/tests/pip/test-solver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,38 @@ solvePip(ymlPrerelease, packages, {}, {}, [], logger, 'linux-64').then(
expect(packageVersions['jupytergis-lab']).toEqual('0.16.0a0');
}
);

const packagesWithMarkupSafe = {
...packages,
'markupsafe-3.0.2-pyhd8ed1ab_0.conda': {
name: 'markupsafe',
build: 'pyhd8ed1ab_0',
version: '3.0.2',
subdir: 'noarch',
channel: 'conda-forge'
}
};

const ymlCaseInsensitiveCondaName = `
dependencies:
- pip:
- MarkupSafe
`;

solvePip(
ymlCaseInsensitiveCondaName,
packagesWithMarkupSafe,
{},
{},
[],
logger
)
.then(result => {
expect(Object.values(result)).toBeEmpty();
expect(logger.logs).toInclude(
'Requirement MarkupSafe already handled by conda/micromamba/mamba.'
);
})
.catch(err => {
throw err;
});
Loading