dym: use fn_addr_eq for function pointer comparison#44654
Merged
Conversation
Signed-off-by: Gal Ovadia <ggalovadia@gmail.com>
ovadiagal
force-pushed
the
govadia/fix-set-factory-once
branch
from
April 24, 2026 19:54
d280b37 to
08cc6ac
Compare
ovadiagal
marked this pull request as ready for review
April 24, 2026 19:55
ovadiagal
requested review from
agrawroh,
mathetake,
mattklein123 and
wbpcode
as code owners
April 24, 2026 19:55
agrawroh
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix to rust dynamic modules SDK.
Came across this issue when trying to bump dynamic-modules-examples to 1.38.0:
Commit Message: dym: use fn_addr_eq for function pointer comparison
Additional Description:
Risk Level: Low
Testing: N/A
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]