Skip to content

New sphere graph - #55

Open
Droxef wants to merge 372 commits into
epfl-lts2:masterfrom
Droxef:new_sphere_graph
Open

New sphere graph#55
Droxef wants to merge 372 commits into
epfl-lts2:masterfrom
Droxef:new_sphere_graph

Conversation

@Droxef

@Droxef Droxef commented Jul 9, 2019

Copy link
Copy Markdown

No description provided.

@nperraud
nperraud requested review from mdeff and nperraud July 16, 2019 06:06
@nperraud

Copy link
Copy Markdown
Collaborator

@mdeff I am not sure, we should have healpy as a dependency. It is a big package that takes time to install and we only use it for one function. What do you think?

@mdeff

mdeff commented Jul 16, 2019

Copy link
Copy Markdown
Collaborator

Absolutely. It should be lazily imported (as matplotlib, pyqtgraph, flann, etc.). That is, it's only imported when the user calls the SphereHealpix constructor, not when the pygsp is imported. The only hard dependencies are numpy and scipy. @Droxef did it correctly.

@Droxef
Droxef force-pushed the new_sphere_graph branch from ceee7ea to 6568611 Compare July 26, 2019 09:53
@mdeff mdeff mentioned this pull request Oct 17, 2019
@mdeff mdeff self-assigned this May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants