Clarify data not uploaded#1179
Conversation
JulienVig
left a comment
JulienVig
left a comment
There was a problem hiding this comment.
A few suggestions but otherwise all good for me! Most important one is the bg and text color for the secure icon text.
Are we giving up the "try with wifi off" idea?
| v-tippy="{ | ||
| content: 'Data always stays on your device and is never shared.', | ||
| }" | ||
| class="bg-green-200 text-green-500 rounded-full hover:cursor-pointer px-2 py-1" |
There was a problem hiding this comment.
I think the colors are a bit off:
- Mallo recommended this website to check the legibility and the current combination fails to pass
- It looks too bright in the dark theme, the bg and text colors should be swapped I believe
- I find the colors in the mockups of Make it extra-clear to users that data is never uploaded #1137 look quite nice
There was a problem hiding this comment.
Thanks for the link ! Colors are more sane now
| <div v-if="noUpload" class="flex justify-center items-center my-1"> | ||
| <span | ||
| v-tippy="{ | ||
| content: 'Data always stays on your device and is never shared.', |
There was a problem hiding this comment.
I think this tooltip doesn't add much to the button text, what do you think of the mockup text: "Your files are read locally in your browser. They are never to our servers or anyone else." ?
There was a problem hiding this comment.
How about
"Your files are read locally in your browser, who can only read them if you manually select them first. They are never sent to our servers or anyone else's. To convince yourself, you can start a training session (without collaboration) while turning off your machine's wifi !"
?
There was a problem hiding this comment.
I find the "manually select" part potentially confusing, what do you think of "Your files are read locally in your browser, they are never sent to our servers or anyone else's. To convince yourself, you can start a local training while turning off your machine's Wi-Fi!"
| @@ -21,13 +32,14 @@ | |||
| <p | |||
| class="p-4 text-lg text-disco-blue dark:text-disco-light-blue flex-wrap justify-center" | |||
There was a problem hiding this comment.
| class="p-4 text-lg text-disco-blue dark:text-disco-light-blue flex-wrap justify-center" | |
| class="p-4 text-lg text-disco-blue dark:text-white flex-wrap justify-center" |
While we're on this part of the code, let's make the dark mode text white like the rest of the page. The light blue isn't very legible
| > | ||
| <section> | ||
| <!-- Hide the file input field when already submitted--> | ||
| <div v-if="noUpload" class="flex justify-center items-center my-1"> |
There was a problem hiding this comment.
| <div v-if="noUpload" class="flex justify-center items-center my-1"> | |
| <div v-if="noUpload" class="flex justify-center items-center my-2"> |
Looks a bit too close to me
2 participants
Changes
(will fix e2e once design is finalized)
Screenshots
Before
After
Hopefully closes #1137