Conversation
afvallejo
commented
Feb 20, 2026
afvallejo
left a comment
Author
There was a problem hiding this comment.
Implemented robust eBayes variance moderation in squeezeVar by replacing the previous NotImplementedError robust branch with the robust fitting path, while preserving existing behavior when robust=False. This is a focused, backward-compatible change that unblocks robust limma workflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(limma): implement robust eBayes variance moderation path
Description and Context
eBayesvariance moderation path in limma by replacing the previousNotImplementedErrorbehavior whenrobust=True.squeezeVarnow uses robust hyperparameter estimation (via robustfitFDistflow) instead of failing.robust=False) remains unchanged to preserve backward compatibility..DS_Storeto.gitignorepytestinpyproject.tomltest extraTypes of changes
Test strategy
NotImplementedError.