fix(pstack): apply shared Bugbot triage in Babysit - #22
Merged
Conversation
ericlitman
marked this pull request as ready for review
August 26, 2026 03:26
|
Tick the box to add this pull request to the merge queue (same as
|
hieusats
pushed a commit
to hieusats/omp-pstack
that referenced
this pull request
Aug 30, 2026
…t-babysit fix(pstack): apply shared Bugbot triage in Babysit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20
Why
The standalone Babysit skill did not use the fix/dismiss/ask policy already required by poteto-mode Babysit. The same review-bot comment could therefore receive different treatment depending on which entry point handled it.
What changed
poteto-mode/references/bugbot-triage.mdand link to it from both Babysit entry points.Tradeoffs
The check intentionally inspects the two operational lines instead of accepting the path anywhere in either file. It does not copy or edit the rubric, merge the entry points, or add a new test helper.
Blast radius
The behavior change is limited to review-bot triage in the independently authored standalone Babysit skill. The poteto-mode playbook and canonical rubric remain byte-for-byte unchanged. Open Pstack stays at 1.1.0 pending the consolidated minor release.
Verification
Local verification:
bun run test: 101 passed, 0 failed, 451 assertions across 10 files.bun run typecheck: passed.PSTACK_STATIC_ONLY=1 bash tests/skill-collision-repro.sh: passed.Live evidence:
4bf252ca7011d09db519a42524ce3e0a1f17fec7.pstack@open-pstack1.1.0 from its installed cache, resolved the standalone relative link to the canonical rubric, found both Babysit bindings and exactly one rubric, then classified the four probes as fix/dismiss/ask/ask.pstack@open-pstack1.1.0 from its installed cache, resolved the same relative link, found both bindings and exactly one rubric, then classified the probes as fix/ask/ask/ask.dismisswith concrete disproof and the rubric's securityaskdefault. This PR leaves the canonical rubric unchanged as scoped; both surfaces escalated the unambiguous auth, permission-boundary, and migration probe.