Skip to content

fix(architect): run Sol at xhigh - #29

Closed
carlcayton wants to merge 1 commit into
ericlitman:mainfrom
carlcayton:fix/architect-sol-xhigh
Closed

fix(architect): run Sol at xhigh#29
carlcayton wants to merge 1 commit into
ericlitman:mainfrom
carlcayton:fix/architect-sol-xhigh

Conversation

@carlcayton

@carlcayton carlcayton commented Aug 29, 2026

Copy link
Copy Markdown

Why

Architect is the only default pstack role that should use GPT-5.6 Sol at xhigh. The other Sol routes should remain at max.

Closes #28.

Scope

  • Change the Architect runner descriptor from codex:gpt-5.6-sol@max to codex:gpt-5.6-sol@xhigh.
  • Preserve Architect xhigh as a fixed exception when setup parses, probes, and renders configurable per-family efforts.
  • Update TypeScript and shell routing invariants so Architect must use xhigh while every other default panel retains the matrix effort.

Blast Radius

The change is limited to Architect routing, setup-pstack handling, and routing contract tests. Provider dispatch and every other role retain their existing model effort.

Verification

  • quick_validate.py passed for architect and setup-pstack.
  • bun run typecheck passed.
  • PSTACK_STATIC_ONLY=1 bash tests/skill-collision-repro.sh passed.
  • bun run test passed 154 of 155 tests. The remaining runner/run.test.ts failure, terminalizes catchable failures after reserving output paths, is unrelated and reproduces outside this patch.
  • The exact Architect candidate is installed in the active pstack 1.0.5 cache.
  • Native Codex Architect smoke returned ARCHITECT_SOL_XHIGH_NATIVE_OK.
  • Claude-parent external Codex smoke returned ARCHITECT_SOL_XHIGH_EXTERNAL_OK, with the receipt recording gpt-5.6-sol and xhigh.

@mergify

mergify Bot commented Aug 29, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@greptile-apps

greptile-apps Bot commented Aug 29, 2026

Copy link
Copy Markdown

Greptile Summary

This PR changes Architect's default GPT-5.6 Sol effort from max to xhigh while retaining max for the other Sol routes.

  • Updates Architect and setup skill descriptors and confirmation text.
  • Expands setup probing and smoke guidance to cover both distinct Sol effort descriptors.
  • Revises the static routing invariant to check the Architect-specific exception separately.

Confidence Score: 4/5

The PR appears safe to merge, with one non-blocking maintainability issue in the model-swap robustness of the static routing invariant.

The current descriptors and expected quads are consistent, but the new test couples Architect's effort override to the exact current Sol model slug and may stop enforcing the intended invariant correctly after a frontier-model update.

Files Needing Attention: tests/skill-collision-repro.sh

Important Files Changed

Filename Overview
plugins/pstack/skills/architect/SKILL.md Correctly changes only Architect's Sol runner descriptor from max to xhigh.
plugins/pstack/skills/setup-pstack/SKILL.md Consistently documents, probes, and presents Architect's distinct xhigh Sol route.
tests/skill-collision-repro.sh Enforces the new routing split, but derives the Architect expectation through a model-slug-specific substitution that will become stale on a future Sol model swap.

Reviews (1): Last reviewed commit: "fix(architect): run Sol at xhigh" | Re-trigger Greptile

dispatch="$repo/plugins/pstack/skills/poteto-mode/references/provider-dispatch.md"
quad_of() { { grep -oE '(claude|codex|grok):[a-z0-9.-]+@(low|medium|high|xhigh|max)' || true; } | tr '\n' ' ' | sed 's/ $//'; }
canon_quad="$(sed -n '/^The frontier defaults are:/,/^## /p' "$dispatch" | quad_of || true)"
architect_quad="$(printf '%s\n' "$canon_quad" | sed 's/codex:gpt-5\.6-sol@max/codex:gpt-5.6-sol@xhigh/')"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Model-specific invariant derivation

The Architect expectation replaces only the exact gpt-5.6-sol@max descriptor, so a future Codex model swap makes the substitution a no-op and causes the invariant to reject a correct xhigh route or accept an incorrect canonical max route.

Suggested change
architect_quad="$(printf '%s\n' "$canon_quad" | sed 's/codex:gpt-5\.6-sol@max/codex:gpt-5.6-sol@xhigh/')"
architect_quad="$(printf '%s\n' "$canon_quad" | sed -E 's/(codex:[a-z0-9.-]+)@max/\1@xhigh/')"

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Keep Sol max for the other panel and single-role defaults. Update setup probes and the static routing invariant for the Architect exception.
@carlcayton
carlcayton force-pushed the fix/architect-sol-xhigh branch from 7d9d32b to 9dd5ce2 Compare August 29, 2026 23:54
@carlcayton

Copy link
Copy Markdown
Author

Closing because this was scoped incorrectly. The requested change is local to Herdr-launched Codex CLIs, not upstream pstack.

@carlcayton carlcayton closed this Aug 30, 2026
@carlcayton
carlcayton deleted the fix/architect-sol-xhigh branch August 30, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use GPT-5.6 Sol xhigh for architect runners

1 participant