fix(architect): run Sol at xhigh - #29
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Greptile SummaryThis PR changes Architect's default GPT-5.6 Sol effort from
Confidence Score: 4/5The PR appears safe to merge, with one non-blocking maintainability issue in the model-swap robustness of the static routing invariant. The current descriptors and expected quads are consistent, but the new test couples Architect's effort override to the exact current Sol model slug and may stop enforcing the intended invariant correctly after a frontier-model update. Files Needing Attention: tests/skill-collision-repro.sh
|
| Filename | Overview |
|---|---|
| plugins/pstack/skills/architect/SKILL.md | Correctly changes only Architect's Sol runner descriptor from max to xhigh. |
| plugins/pstack/skills/setup-pstack/SKILL.md | Consistently documents, probes, and presents Architect's distinct xhigh Sol route. |
| tests/skill-collision-repro.sh | Enforces the new routing split, but derives the Architect expectation through a model-slug-specific substitution that will become stale on a future Sol model swap. |
Reviews (1): Last reviewed commit: "fix(architect): run Sol at xhigh" | Re-trigger Greptile
| dispatch="$repo/plugins/pstack/skills/poteto-mode/references/provider-dispatch.md" | ||
| quad_of() { { grep -oE '(claude|codex|grok):[a-z0-9.-]+@(low|medium|high|xhigh|max)' || true; } | tr '\n' ' ' | sed 's/ $//'; } | ||
| canon_quad="$(sed -n '/^The frontier defaults are:/,/^## /p' "$dispatch" | quad_of || true)" | ||
| architect_quad="$(printf '%s\n' "$canon_quad" | sed 's/codex:gpt-5\.6-sol@max/codex:gpt-5.6-sol@xhigh/')" |
There was a problem hiding this comment.
Model-specific invariant derivation
The Architect expectation replaces only the exact gpt-5.6-sol@max descriptor, so a future Codex model swap makes the substitution a no-op and causes the invariant to reject a correct xhigh route or accept an incorrect canonical max route.
| architect_quad="$(printf '%s\n' "$canon_quad" | sed 's/codex:gpt-5\.6-sol@max/codex:gpt-5.6-sol@xhigh/')" | |
| architect_quad="$(printf '%s\n' "$canon_quad" | sed -E 's/(codex:[a-z0-9.-]+)@max/\1@xhigh/')" |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Keep Sol max for the other panel and single-role defaults. Update setup probes and the static routing invariant for the Architect exception.
7d9d32b to
9dd5ce2
Compare
|
Closing because this was scoped incorrectly. The requested change is local to Herdr-launched Codex CLIs, not upstream pstack. |
Why
Architect is the only default pstack role that should use GPT-5.6 Sol at xhigh. The other Sol routes should remain at max.
Closes #28.
Scope
Blast Radius
The change is limited to Architect routing, setup-pstack handling, and routing contract tests. Provider dispatch and every other role retain their existing model effort.
Verification