Skip to content

feat: roll out Batch 1 core application visuals - #1322

Merged
ericsocrat merged 4 commits into
mainfrom
codex/whole-product-batch1
Aug 28, 2026
Merged

feat: roll out Batch 1 core application visuals#1322
ericsocrat merged 4 commits into
mainfrom
codex/whole-product-batch1

Conversation

@ericsocrat

@ericsocrat ericsocrat commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Pull Request

Summary

Rolls the approved Source Fold / Folded Label Register / Evidence Register visual system through the Batch 1 authenticated core: app shell, navigation, onboarding, Search, Categories, and their shared product-record language.

Related Issue

Batch 1 of the authorized whole-product visual rollout.

Changes

  • Unifies desktop, tablet, and mobile navigation around one route model, with Search and Scan prominent and admin visibility consistent.
  • Adds reusable folded TryVit identity, app-page chrome, shell styling, loading boundary, and ProductRegisterCard primitives.
  • Migrates the existing three-step onboarding flow without changing preference or auth semantics; successful completion and skip lead directly to Search.
  • Reworks Search, autocomplete, category overview, and category listing states for operational density across 390, 768, and 1440 widths.
  • Keeps score, evidence, warning, and ranking language fail-closed; score-sorted category results never become a recommendation without comparable provenance.
  • Updates EN/PL/DE copy, focused component/route tests, a guarded Chromium journey, the changelog, and deterministic live-route inventory.
  • Does not modify dependencies, scoring, auth/provider behavior, database schema/data, landing/Login baselines, or performance policy.

Testing

  • Tests added/updated for all changes
  • Local full suite is green on Windows: affected tests pass, but two base-owned global checks remain Windows-only red (LF byte assay checkout and the existing 15-second renderer mutation timeout); Linux PR Gate is authoritative.
  • npm run type-check
  • npm run lint
  • npm run build
  • npm run design-system:check — 256 tests
  • Final affected suite — 107 tests
  • Earlier integrated Search/Categories/shared-card suite — 143 tests
  • Shell/onboarding suite — 158 tests
  • Guarded Chromium review at 390x844, 768x1024, and 1440x900 in light/dark
  • Guarded onboarding mobile-light/desktop-dark capture and full three-step flow
  • Native mobile More-dialog browser check
  • scripts/repo_verify.ps1 — 6/6
  • Deterministic live inventory regenerated twice with identical SHA-256
  • No Lighthouse run

Accessibility and performance

  • Uses native modal-dialog semantics, restores focus, preserves visible focus, 44px touch targets, safe areas, forced colors, reduced motion, status/error announcements, and adaptive dark-theme contrast.
  • Avoids per-card provenance query fan-out and adds no dependencies. Route-JS remains a CI gate.

Visual baseline disposition

The two authenticated new-user app-shell baselines were accepted through exact-source baseline PR #1323 and merged at fde1e27723409f1eb49207f50e758795b54748bf. This branch then merged that exact main ancestry normally; the synchronization changed only the accepted manifest and two app-shell PNGs. All landing and Login baseline hashes/bytes remain unchanged.

Documentation Checklist

  • No new api_* function without API_CONTRACTS.md update
  • No scoring change without SCORING_METHODOLOGY.md update
  • No new migration without copilot-instructions.md schema check
  • Last updated refreshed on any modified doc (not applicable; deterministic JSON inventory only)
  • New .md files added to docs/INDEX.md (not applicable)
  • CHANGELOG.md updated under [Unreleased]

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tryvit Ready Ready Preview Aug 28, 2026 1:20am

@ericsocrat
ericsocrat marked this pull request as ready for review August 28, 2026 00:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a6fc934e44

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/src/app/app/layout.tsx Outdated
@ericsocrat

Copy link
Copy Markdown
Owner Author

Final exact-head visual equivalence certification:

  • source head: 38b03569eb02a7e84a0f413f4bddebf7e445984e
  • source tree: 8b2f0bc2cd25509ff90b4e36be69ecb073ba47b9
  • two-pass candidate workflow: 33132497445 — PASS
  • determinism: byte-identical — PASS
  • accepted app-shell PNGs: 390x844 and 1440x900 byte-identical — PASS
  • landing/Login PNGs: all five byte-identical — PASS
  • manifest delta versus accepted main: source commit and derived checksum only
  • no new baseline PR required
  • Lighthouse measurement steps: not run

@ericsocrat
ericsocrat merged commit 1763c1e into main Aug 28, 2026
24 of 26 checks passed
@ericsocrat
ericsocrat deleted the codex/whole-product-batch1 branch August 28, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant