feat: roll out Batch 2 product intelligence visuals - #1324
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Batch 2 exact-head certification: HOLD MERGE
Product-relevant gates PASS: PR Gate, CodeQL, Quality Gate, Golden Reference, Route-JS, immutable comparator, intentional-redesign validation, repo hygiene, screenshots, and Vercel preview. Open code-scanning alerts: 0. Open secret-scanning alerts: 0. Unresolved review threads: 0. Lighthouse was intentionally cancelled during dependency installation. Both measurement steps were skipped; no new samples were produced. Inherited renderer attestation remains failed on exact base-owned policy tests and is not caused by this PR. Sonar merge hold:
Keep this PR draft and unmerged until those Sonar dispositions are completed. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 092168418d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <span | ||
| className={styles.badge} | ||
| data-testid="nav-badge-lists" | ||
| aria-hidden="true" |
There was a problem hiding this comment.
Keep navigation badge counts accessible
When listCount or compareCount is positive, aria-hidden removes the only count text from the accessibility tree, while this change also deletes the count-bearing aria-label; screen readers therefore announce only “Lists” or “More” and cannot discover the badge’s list or selected-product count. Preserve the visible-label-in-name fix with label-first accessible text such as “Lists, 3 items” or an equivalent visually hidden description.
Useful? React with 👍 / 👎.
Purpose
Roll the approved Folded Label Register and Evidence Register visual language through Batch 2 product-intelligence routes without changing scoring, provenance semantics, mutation behavior, database policy, dependencies, baselines, or performance methodology.
Behavior changes
Verification
Passed locally:
Local environment-only failures:
Accessibility
Performance
Visual evidence
The guarded run produced transient review screenshots for Product summary, analysis, alternatives, Compare, Watchlist, and Lists at 390x844, 768x1024, and 1440x900 in light/dark, plus a forced-colors product state. Baseline files remain byte-identical.
Merge hold
Keep this PR draft and unmerged until:
The Sonar false-positive control was unavailable locally because both safe browser sessions were signed out. No quality profile, threshold, Auth code, or provider configuration was changed.
Not run