feat: complete whole-product visual rollout Batch 3 - #1325
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📸 PR ScreenshotsCaptured 2 screenshots (1 mobile, 1 desktop) for 1 changed page(s):
📥 Download screenshots from workflow artifacts. Captured by PR Screenshots workflow • 2026-08-28 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 72f8f87c97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| return ( | ||
| <div className={styles.shell}> | ||
| <Header /> |
There was a problem hiding this comment.
Provide live auth state to the public header
When an authenticated user visits any route using this new shell, the header always renders the “Sign in” action because LiveHeaderAuthAction reads a context whose default is false, and LivePublicAuthProvider is only mounted by HomePageContent. As a result, the newly migrated shared-list, shared-comparison, offline, and forbidden pages show an incorrect auth state and send signed-in users through /auth/login rather than directly to the dashboard; wrap this shell/header with the live auth provider or otherwise supply the actual session state.
Useful? React with 👍 / 👎.
| <ProductRegisterCard | ||
| key={item.product_id} | ||
| productId={item.product_id} | ||
| href={`/app/product/${item.product_id}`} |
There was a problem hiding this comment.
Keep shared-list product links on an anonymous route
For signed-out visitors—the primary audience of this public share route—every newly clickable product row now points into /app, which the proxy classifies as protected and redirects to login. Thus clicking an item no longer provides product details within the shared experience and unexpectedly abandons the anonymous flow; use an anonymously accessible product destination or render these rows as non-links until one exists.
Useful? React with 👍 / 👎.
Purpose
Complete whole-product visual rollout Batch 3 for the remaining customer-facing Scanner, activity, Settings, product adjunct, anonymous share, Learn, legal, offline, and forbidden surfaces.
Behavior
c7a143394f3c0d74a472ddf212f2519962bab85bVerification
Visual evidence
Guarded local screenshots were generated for each review state but are intentionally not committed as immutable evidence or baselines. The PR preview and ordinary screenshot/check workflows remain the review surface.
Accessibility and performance
Documented inherited/local-only checks
f612090fb72b6dca3e807e66fa0d2b5def163cef86f1a3209b5c897cba5ee4b7; immutable bytes were not changedOut of scope
No admin/dev/evidence route migration, Auth/provider change, database/RLS/data mutation, dependency change, baseline update, Lighthouse measurement, or new route family.