XML Export | Add Missing Comment, ChoiceIndex & Length

[DER-SSt]

See #400 for description of issue.

This PR adds additional fields to the XML export.

[sylvesterkaczmarek]

exportChoiceEncodingClass() filters ChoiceAlwaysAbsent into acnChildren for the index/field metadata, but the presence-when test still scans ti.children. An always-absent alternative with a presence condition can therefore make the XML report acnEncodingClass="presence-when" while the exported presence fields and normal backend encoding use only the remaining ACN children. Please base this decision on acnChildren too and add that case.

[DER-SSt]

exportChoiceEncodingClass() filters ChoiceAlwaysAbsent into acnChildren for the index/field metadata, but the presence-when test still scans ti.children. An always-absent alternative with a presence condition can therefore make the XML report acnEncodingClass="presence-when" while the exported presence fields and normal backend encoding use only the remaining ACN children. Please base this decision on acnChildren too and add that case.

Thank you for the quick review!
Does 65848a9 address your concern?

[sylvesterkaczmarek]

Yes. exportChoiceEncodingClass() now derives the presence-when decision and fields from the same acnChildren list that excludes ChoiceAlwaysAbsent, so the XML metadata cannot be driven by an alternative omitted from the exported ACN choice. This resolves my concern.

[DER-SSt]

What are the next steps? Can this be merged?

[sylvesterkaczmarek]

From my review side, yes. I approved the current 65848a9 head and have no remaining change request; the actual merge decision is with the ESA maintainers.

[maxime-esa]

Thanks, we are monitoring and on it ; we had to address a few urgent vulnerarbilities on the XER backend, but this will come next. Sorry for the delay