Skip to content

Handle unset CMake generator on Windows - #58

Open
sylvesterkaczmarek wants to merge 1 commit into
esa:mainfrom
sylvesterkaczmarek:fix/windows-default-cmake-generator
Open

sylvesterkaczmarek wants to merge 1 commit into
esa:mainfrom
sylvesterkaczmarek:fix/windows-default-cmake-generator

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown
  • Treat an unset CMake generator as the default multi-config MSVC case instead of iterating over None.
  • Preserve source builds without a mandatory Ninja installation.

Closes #57

Validation: python -m py_compile setup.py; checked unset, Visual Studio, Ninja and NMake generator cases.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows source build fails when CMake generator is unset

1 participant