Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking opportunity to preserve credential-independent SDK test coverage on fork pull requests. The CI repair paths are consistent with repository toolchain and database configuration, but the no-token SDK fallback unnecessarily suppresses several locally runnable tests. Files Needing Attention: .github/workflows/ci-sdk.yml Prompt To Fix All With AI### Issue 1
.github/workflows/ci-sdk.yml:48
**Credential-free tests are skipped**
For fork pull requests without `ATLAS_TOKEN`, this fallback also skips several tests that use local file or SQLite inputs and do not require Atlas Cloud credentials, unnecessarily reducing OSS test coverage.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "ci: start CockroachDB with public image" | Re-trigger Greptile |
| fi | ||
| working-directory: ${{ matrix.module }} | ||
| env: | ||
| ATLAS_TOKEN: ${{ secrets.ATLAS_TOKEN }} |
There was a problem hiding this comment.
Credential-free tests are skipped
For fork pull requests without ATLAS_TOKEN, this fallback also skips several tests that use local file or SQLite inputs and do not require Atlas Cloud credentials, unnecessarily reducing OSS test coverage.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/ci-sdk.yml
Line: 48
Comment:
**Credential-free tests are skipped**
For fork pull requests without `ATLAS_TOKEN`, this fallback also skips several tests that use local file or SQLite inputs and do not require Atlas Cloud credentials, unnecessarily reducing OSS test coverage.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Thanks for flagging this. I independently reproduced the no-token path with the same Atlas v1.3.3-7c4a0e6-canary binary, a clean HOME, and local SQLite/file inputs. The three lint subtests fail with the Atlas Pro entitlement message, and TestMigrate_Diff fails because migrate diff --dry-run is Pro-gated. These tests therefore cannot run successfully on fork PRs without ATLAS_TOKEN; the existing targeted skip is intentional and should remain.
There was a problem hiding this comment.
Thanks for reproducing this with the same canary binary and clean environment. That confirms the three lint subtests and TestMigrate_Diff are genuinely Pro-gated without ATLAS_TOKEN, so the targeted skip is intentional and preserves the appropriate fork-PR behavior. This finding does not apply.
Tip: You can customize Greptile's behavior for this repo with .greptile/rules.md and .greptile/config.json.
## Why? Schema-scoped fan-out plans were falsely rejected as drifted because plan-time realms and apply-time re-inspection used different schema-name representations. ## This PR will... - Preserve scoped schema names correctly while rendering diffs. - Normalize scoped realm fingerprints consistently during planning and apply. - Normalize non-file artifact fingerprints for scoped targets. - Add regression coverage for named-schema normalization and real drift. ## Testing - `go test ./internal/cmdapi -count=1` - Race-enabled TiDB 5, 6, and 8 fan-out/integration suites with `-count=2` - Stacked on #2; merge #2 first.
Why?
The OSS pull-request workflows fail before the feature changes can be validated because of stale action runtimes, a Go toolchain mismatch, fork-inaccessible Pro checks, and unavailable CockroachDB image/startup configuration.
This PR will...
Testing