refactor: use Set instead of Map in no-duplicate-keys - #280
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe duplicate-key rule now uses per-object ChangesDuplicate Key Tracking
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This refactor replaces presence-only Map tracking with Sets while preserving duplicate-key detection behavior. No current merge-blocking risk is identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
A similar refactor to the one in eslint/css#513.
What changes did you make? (Give an overview)
While reviewing the
no-duplicate-keyscode, I found that there was no need to use aMap, so I replaced it with aSet.Related Issues
Ref: eslint/css#513
Is there anything you'd like reviewers to focus on?
N/A
Summary by CodeRabbit